Polymer / old-docs-site

Old Polymer site. Replaced by these repos: polymer-project.org, polymer-library-docs
https://www.polymer-project.org
1.02k stars 2.45k forks source link

nit: Grammar #2656

Closed JohnBergant closed 5 years ago

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
ghost commented 5 years ago

Closing this due to lack of CLA, and a nit regarding the nit :) I think "any of" is singular in this context. Please feel free to re-open and sign the CLA if you get time to link to a grammar site that explains why it's incorrect.

jsilvermist commented 5 years ago

@katejeffreys

The method is invoked to calculate the value whenever any of the argument values changes.

The focal point here isn't "any of", it's "values". With a plural "values", "changes" could only be used in an observation regarding multiple changes, whereas "any" is singular.

The correct way to phrase this would be: The method is invoked to calculate the value whenever any of the argument values change. Or in the case of multiple occurrences: The method is invoked to calculate the value for each of the argument values changes.

TL;DR: A value changes, values change.

ghost commented 5 years ago

The subject of the clause "any of the argument values changes" is the noun phrase "any of the argument values". Can you link to a source that explains why that phrase is plural?