Polymer / old-docs-site

Old Polymer site. Replaced by these repos: polymer-project.org, polymer-library-docs
https://www.polymer-project.org
1.02k stars 2.45k forks source link

Added the missed steps #2664

Closed vidhya03 closed 5 years ago

vidhya03 commented 5 years ago

If we continued as per the documentation , we end up with variable override in :host pesudo classes

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
vidhya03 commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

arthurevans commented 5 years ago

Thanks for the PR. In this case, the instructions are correct. If you follow the instructions, you should see the pressed icon toggle is blue. because that rule is overriding the one in :host.

The docs describe this:

"The demo-element selector matches the element and has a higher specificity than the :host selector inside demo-element. You can use this fact to specify your own values for custom properties that the author of a custom element has defined inside that custom element, without altering the element's code."

Hope that helps. Please feel free to follow up if it's still not working for you.