search

Polymer / polymer

Our original Web Component library.
https://polymer-library.polymer-project.org/
BSD 3-Clause "New" or "Revised" License
22.04k stars 2.01k forks source link

Polymer.dom(element).innerHTML setter exceptioning #4021

Closed e111077 closed 7 years ago

e111077 commented 7 years ago

Description

In Polymer2, when setting the innerHTML of an element using the Polymer.dom API, it throws an exception pointing to the setter function in the forwardProperties function in polymer.dom.html

Live Demo

https://jsbin.com/borumacuhu/1/edit?html,console,output

Steps to Reproduce

  1. Select an element and save it to a variable, a
  2. Call Polymer.dom(a).innerHTML = 'asdasdfjaslk;djfa'

    Expected Results

It should change the innerhtml

Actual Results

throws an error

Versions

frankiefu commented 7 years ago

See the same issue, seems related to this commit: https://github.com/Polymer/polymer/commit/79dcd2f88a3c71e128a9a49e3174379c89de95e3#commitcomment-19245432

jfrazzano commented 7 years ago

Beat me to the punch, as always, Framkie.

Issues I think also relate to an implimentation on spe. Of template strings

I saw it in a handler attempt to hit inner HTML out of scope of the template replace mrs

sorvell commented 7 years ago

Fixed via https://github.com/Polymer/polymer/pull/4030.