IE11 error w/ dom-repeat as slot content

robrez commented 6 years ago

Description

Pre-Conditions

IE11
Polymer2 project built using the es5-bundled preset

An error is raised when the slot content of a custom element is a dom-repeat and the dom-repeat's items array is changed. This maybe an caused ultimately by dom-api polyfill...

A dom mutation error (NoModificationAllowedError) was triggerd in dom-repeat's detachInstances function https://github.com/Polymer/polymer/blob/master/lib/elements/dom-repeat.html#L560
The error is caught, rethrown here https://github.com/Polymer/polymer/blob/master/lib/utils/async.html#L34

The error can be avoided if the dom-repeat is wrapped in a div and the div is used as the slot content eg:

  <!-- error -->
  <x-slot>
    <template is="dom-repeat" items="[[data]]"></template>
  </x-slot>

  <!-- NO error -->
  <x-slot>
    <div>
      <template is="dom-repeat" items="[[data]]"></template>
     </div>
  </x-slot>

Live Demo

http://jsbin.com/zasusaqode/edit?html,output

Steps to Reproduce

Create an element that accepts slot content
Use a dom-repeat for the slot content
Change the dom-repeat's items array
Use ie11

Expected Results

Items are rendered without error

Actual Results

Rendering generates an error

Browsers Affected

[ ] Chrome
[ ] Firefox
[ ] Edge
[ ] Safari 9
[ ] Safari 8
[X] IE 11 Only tested chrome and ie

Versions

Polymer: v2.1.1
webcomponents: v1.0.14
shadycss: v1.0.6
polymer-cli: v1.5.4
os: windows 7 pro x64

dfreedm commented 6 years ago

Probably a ShadyDOM issue

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically closed after being marked stale. If you're still facing this problem with the above solution, please comment and we'll reopen!

Polymer / polymer