Previously, the orderedComputed algorithm started at the element's properties to build the DAG of edges used to sort the computed effects. However, this would miss any undeclared dependencies of computed properties, causing those computed properties to fail to be correctly inserted into the final order.
This change builds the "ready" list of properties from the keys of the computed effects (properties that kick off computed effects) rather than properties, which removes the footgun around undeclared dependencies.
Previously, the
orderedComputedalgorithm started at the element'spropertiesto build the DAG of edges used to sort the computed effects. However, this would miss any undeclared dependencies of computed properties, causing those computed properties to fail to be correctly inserted into the final order.This change builds the "ready" list of properties from the keys of the computed effects (properties that kick off computed effects) rather than
properties, which removes the footgun around undeclared dependencies.