Polymer / polymer

Our original Web Component library.
https://polymer-library.polymer-project.org/
BSD 3-Clause "New" or "Revised" License
22.04k stars 2.01k forks source link

Attempt to sync host properties on every call to _showHideChildren. #5571

Closed kevinpschaaf closed 5 years ago

kevinpschaaf commented 5 years ago

Fixes an issue where a dom-if that is toggled synchronously true-false-true could fail to sync properties invalidated while false, since the hidden state is only checked at async render timing, and the newly added dirty-check could means nothing happens if the hidden state has been changed back to its previous value at last render.

Since __syncHostProperties has its own fast-path if there is nothing to sync, it need not be gated on the hidden dirty-check in `_showHideChildren).