paladox
commented
5 years ago I've found a replacement i think https://gerrit-review.googlesource.com/c/gerrit/+/233774
Closed paladox closed 5 years ago
paladox
commented
5 years ago I've found a replacement i think https://gerrit-review.googlesource.com/c/gerrit/+/233774
Description
Gerrit uses Polymer 1 and is currently migrating to Polymer 2. I noticed that gr-reply-dialog uses 'addedKeys' which is removed from Polymer 2. You can see here https://github.com/GerritCodeReview/gerrit/blob/master/polygerrit-ui/app/elements/change/gr-reply-dialog/gr-reply-dialog.js#L334 (it throws an error which you can see at https://polymer2-gerrit-review.googlesource.com/c/gerrit/+/233772 in the console log (when adding reviewers).
What is the replacement? Or how do i migrate to an alternative?
Live Demo
You can see it at https://polymer2-gerrit-review.googlesource.com/c/gerrit/+/233772 (click add reviewer then type in a reviewer, then check console).
Steps to Reproduce
Use 'addedKeys' from splices.
Expected Results
there to be no error and it to work
Actual Results
a js error is thrown (reported the error here https://bugs.chromium.org/p/gerrit/issues/detail?id=11299)
Browsers Affected
Versions