Polymer / polymer

Our original Web Component library.
https://polymer-library.polymer-project.org/
BSD 3-Clause "New" or "Revised" License
22.05k stars 2.02k forks source link

Fix a minification issue with the `__hasRegisterFinished` property. #5584

Closed bicknellr closed 5 years ago

bicknellr commented 5 years ago

Wrap hasOwnProperty checks for __hasRegisterFinished in JSCompiler_renameProperty().

bicknellr commented 5 years ago

I've never actually used JSCompiler_renameProperty and I wasn't able to find any documentation about the two-argument form, but from other uses I gathered that the second argument was meant to be the thing that you're going to pull the property from (i.e. thing[JSCompiler_renameProperty('propName', thing)]). Is that correct?