search

Polymer / polymer

Our original Web Component library.
https://polymer-library.polymer-project.org/
BSD 3-Clause "New" or "Revised" License
22.05k stars 2.02k forks source link

Add module field #5594

Closed rslawik closed 4 years ago

rslawik commented 4 years ago

https://unpkg.com/@polymer/polymer@3.3.0?module fails to load saying that the package is not an ES module. Adding module field should allow it to load (see: https://github.com/mjackson/unpkg/blob/4bb6cf424a6f7e803fc98c13662ee4d04bfe4af2/modules/middleware/validateFilename.js#L7)

justinfagnani commented 4 years ago

@azakus @kevinpschaaf how do we maintain the CHANGELOG in Polymer? Is it generated or updated by hand?

kevinpschaaf commented 4 years ago

Yeah, the changelog in the polymer repro predates when we made changelogs per PR; we run a script at release time to gather the commit log.

rslawik commented 4 years ago

If the changelog is updated automatically, can we merge this PR in?

rslawik commented 4 years ago

Ping. It seems that the CHANGELOG update is not a blocker to merge this. @justinfagnani @azakus

Once merged, when is it expected to be published to npm?