search

Polymer / polymer

Our original Web Component library.
https://polymer-library.polymer-project.org/
BSD 3-Clause "New" or "Revised" License
22.05k stars 2.02k forks source link

Add node field to PolymerDomApi #5598

Closed rictic closed 4 years ago

rictic commented 4 years ago

And keep DomApiNative type compatible with PolymerDomApi.

Upstreaming cl/275091781

aomarks commented 4 years ago

I think this should go to legacy-undefined-noBatch, since that's what Google tracks?

kevinpschaaf commented 4 years ago

Either place... we're regularly merging master into legacy-undefined-noBatch.

kevinpschaaf commented 4 years ago

Curious what was relying on node? It's basically an implementation detail of the PolymerDomAPI class (despite it not being prefixed), so it smells odd that something would reference it.

rictic commented 4 years ago

It looks like it's from a desire to unwrap a PolymerDomApi value back to its underlying dom value in order to pass it to a basic DOM handling API. Might have been totally based on a type error from the compiler and it may have worked fine at runtime, in which case maybe they should just cast the PolymerDomApi as a Node instead.

To check out the code, see http://cs/setPolymerNodeContent

kevinpschaaf commented 4 years ago

@sorvell Can you review?