Polymer / polymer

Our original Web Component library.
https://polymer-library.polymer-project.org/
BSD 3-Clause "New" or "Revised" License
22.05k stars 2.01k forks source link

v3.4.0 release notes and commit list #5644

Closed bicknellr closed 4 years ago

bicknellr commented 4 years ago

Adds release notes for all the new and changed behavior I could find in the legacy-undefined-noBatch branch. I still need to collect some more info about the feasibility of new behavior around constructable stylesheets. (This behavior is now behind a flag: useAdoptedStyleSheetsWithBuiltCSS.)

bicknellr commented 4 years ago

I added a section on useAdoptedStyleSheetsWithBuiltCSS, PTAL

bicknellr commented 4 years ago

I was just trying out ./util/gen-changelog.sh and it puts commit messages in a list above the old changelog content. I'd like to put these above the raw list of commits, so I wonder if this PR would be better if it went into master as part of the typical post-release changelog commit rather than editing the changelog as part of this branch?

bicknellr commented 4 years ago

Is that fix enabled by default? (i.e. unrelated to if reuseChunkedInstances is set)

kevinpschaaf commented 4 years ago

Right, it's an unconditional fix to a behavior that regressed in Polymer 2/3 vs. Polymer 1.

bicknellr commented 4 years ago

Ok, added, PTAL. Also, what do you think about the PR-moving situation I mentioned earlier?

bicknellr commented 4 years ago

Ok, I'll wait until https://github.com/Polymer/polymer/pull/5497 is released and then add the commit log to this PR.