Polymer / polymer

Our original Web Component library.
https://polymer-library.polymer-project.org/
BSD 3-Clause "New" or "Revised" License
22.04k stars 2.01k forks source link

Polymer Gestures SyntaxError: The string did not match the expected pattern. #5677

Closed SirJackovich closed 3 years ago

SirJackovich commented 3 years ago

Description

In safari on an iPhone when you click a checkbox you get the following console error: SyntaxError: The string did not match the expected pattern.

Here is our example: `

` The error is on this line: https://github.com/Polymer/polymer/blob/master/lib/utils/gestures.js#L150 ` let matching = root.querySelectorAll(`label[for = ${el.id}]`);` When that line is changed to ` let matching = root.querySelectorAll(`label[for = '${el.id}']`);` the error does not occur
SirJackovich commented 3 years ago

Thanks for merging that, is there a way this could get merged into polymer v2?

SirJackovich commented 3 years ago

@dfreedm