search

Polymer / prpl-server

⚠️Maintenance mode⚠️ An HTTP server for Node designed to serve PRPL apps in production.
Other
425 stars 29 forks source link

Headers | link: rel=modulepreload support/capability #106

Closed patriciatrauman closed 3 years ago

patriciatrauman commented 3 years ago

So far, all link are set as rel=preload. It could be useful to choose if we want preload or modulepreload. So the browser wouldn't load twice a module file and avoid this kind of warning Screenshot 2021-06-18 at 15 47 59

To do so, we could add an optional argument to push-manifest.json. This could be implemented in https://github.com/Polymer/prpl-server/blob/master/src/push.ts

Here is a possible implementation :

Screenshot 2021-06-18 at 15 09 46 Screenshot 2021-06-18 at 15 10 03 Screenshot 2021-06-18 at 15 10 26 Screenshot 2021-06-18 at 15 13 28 Screenshot 2021-06-18 at 15 10 43

@aomarks What do you think ? Does it make sense ?

references : https://developers.google.com/web/updates/2017/12/modulepreload https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types/modulepreload

aomarks commented 3 years ago

Thank you for the feature request. Closing because we are no longer accepting new feature requests for prpl-server.

See https://github.com/Polymer/prpl-server#prpl-server for our recently added maintenance mode notice, and recommendations for alternatives.