Polymer / pwa-helpers

Small helper methods or mixins to help you build web apps.
BSD 3-Clause "New" or "Revised" License
440 stars 48 forks source link

Add axe core helper #15

Closed notwaldorf closed 6 years ago

notwaldorf commented 6 years ago

This PR is bigger than I would have hoped, and I'm sorry. I:

The demo for the reporter looks like this:

screen shot 2018-04-04 at 3 36 30 pm

The demo for the redux bit looks like this:

screen shot 2018-04-04 at 3 37 11 pm
keanulee commented 6 years ago

I consider this a test helper, not a production app helper, so I don't know how much it belongs in this repo. Welcome other opinions though.

notwaldorf commented 6 years ago

I was thinking that if we make it easily available, and you already added pwa-helpers to your app, then you might be more likely to add some a11y testing to your app (which is part of it being "production" ready imo)

frankiefu commented 6 years ago

What do you think making axe-report.js in its own section (e.g. Test helpers) in the README and in the demo page?

Basic helpers
-----
router.js
network.js
metadata.js
media-query.js

Redux helpers
-----
connect-mixin.js
lazy-reducer-enhancer.js

Test helper
-----
axe-report.js

Btw, love the demo.

notwaldorf commented 6 years ago

I really like the "Test helpers" idea, will add it to the readme and the demo.