Polymer / pwa-helpers

Small helper methods or mixins to help you build web apps.
BSD 3-Clause "New" or "Revised" License
439 stars 48 forks source link

Add twitterCard option to metadata #53

Closed abdonrd closed 5 years ago

abdonrd commented 5 years ago

Option to update the theme-color meta tag.

<meta name="twitter-card" content="summary">

Reference: https://developer.twitter.com/en/docs/tweets/optimize-with-cards/overview/summary

Just check https://github.com/Polymer/pwa-helpers/commit/a4b56fd048cac57931e1aa7c76524687c502af9a. When https://github.com/Polymer/pwa-helpers/pull/47 is merged, I can rebase it to master.

abdonrd commented 5 years ago

About this: https://github.com/Polymer/pwa-helpers/pull/47#issuecomment-437193056

Why not have Twitter-specific when it is so common in applications?

keanulee commented 5 years ago

My thinking with this and themeColor (#52) is this:

abdonrd commented 5 years ago

My use case is:

And what updateLocation() callback?

jsilvermist commented 5 years ago

Perhaps it'd be useful if we exported the _setMeta function (renamed of course), then you can set whatever meta tags.

I think that's really the best option here.

keanulee commented 5 years ago

Added setMetaTag() to set arbitrary meta tag in #58