Add image width & height options to metadata

Polymer / pwa-helpers

Small helper methods or mixins to help you build web apps.

BSD 3-Clause "New" or "Revised" License

439 stars 48 forks source link

Add image width & height options to metadata #56

Closed abdonrd closed 5 years ago

abdonrd commented 5 years ago

Recommended by Facebook:

2. Use og:image:width and og:image:height Open Graph tags

Using these tags will specify the image dimensions to the crawler so that it can render the image immediately without having to asynchronously download and process it.

Reference: https://developers.facebook.com/docs/sharing/best-practices/

keanulee commented 5 years ago

Added setMetaTag() to set arbitrary meta tag in #58

abdonrd commented 5 years ago

As we have the other og meta tags, do not you think it would be worthwhile to accept this PR? The others understand that they are rejected.

keanulee commented 5 years ago

I don't want to add the universe of og meta tags, so figured it's better to expose the function. Actually thinking about removing image and imageAlt (basically all the cases that just call setMetaTag once), but that would be breaking.