Closed lozandier closed 5 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
CLAs look good, thanks!
@frankiefu Changes done; think the review comments 'disappeared' when I interactive rebased.
Summary of Change
Adds
z-index: 1
to fix an issue of the children of a page component end up being over app-drawer—especially ifcontain: content
is used on any of the children.Ensures expectations that the z-index of app-drawer is by default higher than the contents of
main
withinmy-app
.Actions taken by change
z-index: 1
to app-drawer in sharedQuestions to consider during review
app-drawer
selector change should be inmy-app.js
render
function.