search

Polymer / pwa-starter-kit

Starter templates for building full-featured Progressive Web Apps from web components.
https://pwa-starter-kit.polymer-project.org
2.36k stars 431 forks source link

Update to new lit-element API #222

Closed keanulee closed 6 years ago

keanulee commented 6 years ago

Fixes #219

keanulee commented 6 years ago

Also some problem with IE11 - doesn't render anything, doesn't load my-view1.js, and no console errors. There is a caught exception about keys though that I didn't see with the previous lit-element version (https://pwa-starter-kit.appspot.com):

image

frankiefu commented 6 years ago

@sorvell @keanulee saw some problem with IE11 and I think it might be caused by this commit: https://github.com/Polymer/lit-element/commit/b39b9795ae0cff2b9e40a5794d2501a0248393ab#diff-c5f280d12b2d91f8b89fe4ac3b6313d8R518

Basically Map.prototype.keys() is not supported in IE11 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map/keys#Browser_compatibility

keanulee commented 6 years ago

@sorvell Suggest using Map.forEach instead

keanulee commented 6 years ago

@sorvell Another IE11-specific issue - subclasses of PageViewElement need to re-declare active: { type: BooleanAttribute } in the properties block even though it's already declared in PageViewElement. Otherwise the active property isn't registered.