Polymer / pwa-starter-kit

Starter templates for building full-featured Progressive Web Apps from web components.
https://pwa-starter-kit.polymer-project.org
2.36k stars 431 forks source link

[Redux DevTools] Uncaught Error: You may not call store.getState() while the reducer is executing. #275

Closed Dabolus closed 5 years ago

Dabolus commented 5 years ago

Currently, the Starter Kit is not working at all because of an "Uncaught Error":

image

This issue is not related to the Starter Kit itself, but it is caused by the latest version of Redux DevTools Extension. I'm creating this issue just to keep track of this so that folks that are going to try the Starter Kit now know why this is happening.

While the issue gets fixed on Redux DevTools extension, these are the things you can do to make it work correctly again:

  1. Temporarily disable or uninstall Redux DevTools Extension
  2. Manually downgrade Redux DevTools Extension to version 2.15.5 (which isn't affected by this issue) by following these steps:
    • Download Redux DevTools Extension version 2.15.5 from here
    • Extract it to some folder
    • Open chrome://extensions
    • Turn on developer mode from top left
    • Click on Load Unpacked and select the folder containing the extracted extension
  3. If testing the Starter Kit locally, temporarily disable (or completely remove) Redux DevTools Extension from src/store.js:24:
    - const devCompose = window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ || compose;
    + const devCompose = /* window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ || */ compose;

Related issue: https://github.com/zalmoxisus/redux-devtools-extension/issues/588

Dabolus commented 5 years ago

Closing this as Redux DevTools Extension 2.16.3 has been released on the store and the issue has been fixed (how fast!)

frankiefu commented 5 years ago

@Dabolus Thanks for the quick report and the detailed workaround. And then followed up with the fix on their end. We really appreciate it.