search

Polymer / pwa-starter-kit

Starter templates for building full-featured Progressive Web Apps from web components.
https://pwa-starter-kit.polymer-project.org
2.36k stars 431 forks source link

Add crossorigin=anonymous to push headers and update esm-amd-loader #288

Closed keanulee closed 5 years ago

keanulee commented 5 years ago

Fixes #254. Deployed to https://pwa-starter-kit.appspot.com/

abdonrd commented 5 years ago

@keanulee @frankiefu Right now I can still see 2 warnings at https://pwa-starter-kit.appspot.com:

screenshot 2018-12-07 at 09 17 08
frankiefu commented 5 years ago

@abdonrd It seems to work for me.

screen shot 2018-12-07 at 9 39 01 am

Make sure you are on Chrome 71 and check the network panel in dev tools to make sure it's not using cached/old version.

abdonrd commented 5 years ago

I was in Chrome 70, it works with 71! Thanks @frankiefu!

abdonrd commented 5 years ago

@keanulee @frankiefu We also need to remove this crossorigin, right?

https://github.com/Polymer/pwa-starter-kit/blob/d53f4cc4e1263cf9c887ab93d79f302c7bcf00f9/index.html#L67

keanulee commented 5 years ago

I didn't see any in dev tools, so I think it doesn't matter if we remove it or not?