search

Polymer / pwa-starter-kit

Starter templates for building full-featured Progressive Web Apps from web components.
https://pwa-starter-kit.polymer-project.org
2.36k stars 431 forks source link

Remove param from _locationChanged #319

Closed unseen1980 closed 5 years ago

unseen1980 commented 5 years ago

Since _locationChanged is not making use of location param probably it can be removed. What do you think?

keanulee commented 5 years ago

I guess _locationChanged should use the param instead of accessing window.location, similar to _offlineChanged(offline). No strong opinion though.

frankiefu commented 5 years ago

Yeah I think better to change _locationChanged to use the param instead of accessing window.location so it's more consistent with the other templates. e.g.

_locationChanged(location) {
    const path = window.decodeURIComponent(location.pathname);
unseen1980 commented 5 years ago

Done, please review again. Thanks