search

Polymer / shop

The Shop app
https://shop.polymer-project.org/
987 stars 494 forks source link

Detail page doesn't load at times - 404 Message #100

Closed jeff-hernandez closed 7 years ago

jeff-hernandez commented 7 years ago

At random times, the detail page of the product doesn't load outputting message 404 page not found.

frankiefu commented 7 years ago

I can't reproduce the issue in the live demo or running shop locally. Can you give us more info on how to reproduce the issue?

mchyb commented 7 years ago

Whenever I open any product detail page and then switch to another category page to open another product page, I get the 404 view. I tested it with the version downloaded directly from github repo and with the one that is downloaded by Polymer CLI.

frankiefu commented 7 years ago

@TimvdLippe This seems to be a bug in the "Add 404 fallback" changes you did. Seems like it's sending show-invalid-url-warning event when it shouldn't. Do you mind taking a look?

mchyb commented 7 years ago

It seems like, after opening an item detail page, the routeData.item property is being updated before routeData.category causing the _computeItem function to run too early.

TimvdLippe commented 7 years ago

Hm yes it appears to be an observer issue. I will take a look tomorrow!

frankiefu commented 7 years ago

Should be fixed now.