search

Polymer / shop

The Shop app
https://shop.polymer-project.org/
986 stars 494 forks source link

shop (from polymer-cli v1.2) is not compatible with Edge #132

Closed RuslanKim closed 7 years ago

RuslanKim commented 7 years ago

2017-06-14_11-36-24

Is there a fix?

RuslanKim commented 7 years ago

when "polymer serve" runs it works with IE11 but does not with latest Edge :(

keanulee commented 7 years ago

This seems to be an issue with Edge 15 which added support for CSS custom properties (the implementation has a bug - see https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/12414257/).

This wasn't an issue before because we relied on the polyfill. We are currently considering whether to force the polyfill on Edge to workaround this issue.

RuslanKim commented 7 years ago

It makes sense, but Polymer website, which is build and based on Polymer too, works perfectly with Edge for some reason .)

frankiefu commented 7 years ago

Fixed in https://github.com/webcomponents/shadycss/pull/120

RuslanKim commented 7 years ago

Bad issues and bad practice, if you have to fix right now right here, just add these into landing html:

<script> //Force all polyfills on for Edge 15 if (window.navigator.userAgent.indexOf("Edge") > -1) { if (window.customElements) { window.customElements.forcePolyfill = true; } ShadyDOM = { force: true }; ShadyCSS = { shimcssproperties: true }; } </script>