[do not merge] Redux-ify

keanulee commented 6 years ago

Opening this WIP PR for comments only.

keanulee commented 6 years ago

Thoughts about the result so far:

Conceptually, I like having all the state managed in one place. It makes the app/data easier to follow.
Right now I still rely on <app-location> in <shop-app> to provide the current window.location and intercept link clicks. This could (should?) be replaced by a JS-only router that listens on window.
There are still some bindings that have not been moved to redux. For example, <shop-list> creates a list of <shop-list-item> and sets the item property on them (similarly with <shop-cart> and <shop-cart-item>). I feel that this is fine since the "state" of the app is still reflected in the store and the choice of doing a Polymer-style binding here is an implementation detail of <shop-list>.

keanulee commented 6 years ago

Closing. For current progress on adding Redux to Shop, see the redux-example-meta and lit-element branches.

Polymer / shop