search

Polymer / shop

The Shop app
https://shop.polymer-project.org/
986 stars 494 forks source link

[do not merge] Lit element #160

Closed keanulee closed 6 years ago

keanulee commented 6 years ago

For review only (still want to keep a separate Redux branch for now).

keanulee commented 6 years ago

PTAL

keanulee commented 6 years ago

@notwaldorf @frankiefu PTAL. I moved the dynamic import() calls to shop-app and moved the initial categories to a fetchCategories action.

googlebot commented 6 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

keanulee commented 6 years ago

Closing - review work is done and we're keeping lit-element as the main branch for pwa-starter-kit style repo.