Closed dafky2000 closed 6 years ago
The purpose to setting withBackdrop
to true is to use IronOverlayBehaviorImpl
's focus trapping behavior (https://github.com/PolymerElements/iron-overlay-behavior/blob/master/iron-overlay-behavior.html#L51). For visual purposes though, we don't want the overlay to show so that's why we set display: none
. This is kind of a hacky solution, but it works!
The code in
src/shop-buy-modal.html
defines that it should be showingbut it is overridden in the _renderOpen...
Was going to do a pull request to remove the line in
_renderOpen
and simply rely onwithBackdrop
but now I'm confused whether the intention is to have a backdrop or not.