Polymer / shop

The Shop app
https://shop.polymer-project.org/
986 stars 494 forks source link

Safari 4 by 4 grid #174

Closed chris1000 closed 6 years ago

chris1000 commented 6 years ago

I'm trying to make the home screen a 4 x 4 grid (Like in Firefox (Left side) and all browsers besides Safari work, for some reason safari won't display a 4x4 grid any help would be extremely appreciated.

Screenshot 1: Left Side - Firefox doing what I'm trying to achieve, Right side - Safari not working Screenshot 2: Code used to achieve the 4x4 grid in Firefox and Chrome screen shot 2018-04-03 at 12 23 56 pm screen shot 2018-04-03 at 12 24 44 pm

keanulee commented 6 years ago

I think there's an issue with :nth-of-type() selectors in Safari Shadow DOM - you can see this with the last two items on https://shop.polymer-project.org/ in Safari (trying to find the WebKit bug, will update if I do). If all the items are the same though, you can just apply those styles on .item instead.

keanulee commented 6 years ago

Couldn't find the WebKit bug so I just filed a new one https://bugs.webkit.org/show_bug.cgi?id=184273

chris1000 commented 6 years ago

It worked like a charm, thank you! screen shot 2018-04-03 at 2 24 25 pm