search

Polymer / shop

The Shop app
https://shop.polymer-project.org/
986 stars 494 forks source link

Fixes credit card number / cvc number validation issue #195

Closed agektmr closed 5 years ago

agektmr commented 5 years ago

In https://shop.polymer-project.org/checkout credit card number field and CVC number field fails to validate the number. This is due to backslash in input[pattern] attribute within template literal being eliminated when rendered.

This patch makes those backslashes doubled so they will be rendered properly.

keanulee commented 5 years ago

I fixed this myself in https://github.com/Polymer/shop/commit/9cd93f99668152cbd048be24e7902563a08225f6 because there was one more escape that needed to be done for the phone number field. It's deployed to https://shop.polymer-project.org. Thanks for the catch!

frankiefu commented 5 years ago

Thanks @keanulee!