search

Polymer / shop

The Shop app
https://shop.polymer-project.org/
987 stars 494 forks source link

Replace iron-localstorage with app-localstorage-document #82

Closed keanulee closed 7 years ago

frankiefu commented 7 years ago

Reloading the app seems to clear the cart data.

frankiefu commented 7 years ago

Sorry, stupid user error, my bad. It's working perfectly. LGTM

ptamarit commented 7 years ago

Hi @keanulee & @frankiefu,

It's probably a dumb question, but why did you migrate from iron-localstorage to app-localstorage-document? Both are official elements and I didn't find anywhere what are the differences between them.

Cheers, Pablo

Boscop commented 7 years ago

@ptamarit I'm wondering the same.

keanulee commented 7 years ago

One difference is that app-localstorage-document coordinates across instances within the same page, but the bigger picture is that the app-storage set of elements are newer and are designed to be able to use other storage providers (e.g. firebase), though we don't use that here.