Polymer / shop

The Shop app
https://shop.polymer-project.org/
992 stars 494 forks source link

Add correct target directory for bower files during `bower install` #90

Closed 1zaak closed 8 years ago

1zaak commented 8 years ago

Not sure why this is not already in the default app, or is it because of my local bower configs?

Anyway, in the default app, bower install installs into client/bower_components which fails to run the app during polymer serve. So I just created a .bowerrc to make it install into the root folder's bower_components.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

keanulee commented 8 years ago

Hi @1zaak

directory defaults to bower_components already (https://github.com/bower/spec/blob/master/config.md#directory), so this shouldn't be required. You may have a .bowerrc in an above directory (https://bower.io/docs/config/#placement--order) which is changing this default behavior.