Does not understand shorthand property definitions

Polymer / tools

Polymer Tools Monorepo

BSD 3-Clause "New" or "Revised" License

430 stars 200 forks source link

Does not understand shorthand property definitions #1443

Closed MaKleSoft closed 5 years ago

MaKleSoft commented 8 years ago

properties: {
    // detected
    propA: {
        type: String
    },
    // not detected
    propB: String
}

The only test I could find for this is https://github.com/Polymer/polymer-analyzer/blob/master/src/test/polymer/polymer2-element-scanner_test.ts which does not seem to account for prop: type-style property definitions.

rictic commented 8 years ago

This would make a pretty good first bug if you're interested!

MaKleSoft commented 8 years ago

I haven't done much work with Typescript yet and I'm just starting to get familiar with the codebase but sure, I'll give it a shot!

rictic commented 8 years ago

Feel free to ask questions here or on slack. I'm @rictic in both places.

MaKleSoft commented 7 years ago

@rictic Sorry I still haven't tackled this but right now I'm pretty tied in with other stuff. It's still on my backlog but if you want to assign it to someone else that's ok, too.

rictic commented 7 years ago

Gotcha. I may take a stab at this sometime this week as part of improving the robustness of our property matching in general.

TimvdLippe commented 7 years ago

Encountered this issue when working on autocompletion of properties. Was an easy fix, submitted in PR #403