Polymer expression parsing: colons are allowed in property names

Polymer / tools

Polymer Tools Monorepo

BSD 3-Clause "New" or "Revised" License

430 stars 200 forks source link

Polymer expression parsing: colons are allowed in property names #1516

Open rictic opened 7 years ago

rictic commented 7 years ago

Polymer will accept syntax like:

<dt>quota</dt> <dd>[[auth.attributes.custom:quota]]</dd>

We shouldn't error out for this syntax.

bennypowers commented 7 years ago

Should add tokens regex in https://github.com/Polymer/polymer-analyzer/blob/5d865418783e56c7724411d2f37c2f974c492aea/src/javascript/javascript-parser.ts#L30

https://github.com/eslint/espree/blob/master/docs/tokens.md

web-padawan commented 7 years ago

BTW, when using data binding with colons, polymer-build fails with a really confusing output:

Error: 2 error(s) occurred during build.
  at BuildAnalyzer._done (/etc/bi-frontend/node_modules/polymer-build/lib/analyzer.js:229:36)
  at BuildAnalyzer.<anonymous> (/etc/bi-frontend/node_modules/polymer-build/lib/analyzer.js:189:26)
  at next (native)
  at fulfilled (/etc/bi-frontend/node_modules/polymer-build/lib/analyzer.js:17:58)
  at process._tickDomainCallback (internal/process/next_tick.js:135:7)

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.