search

Polymer / tools

Polymer Tools Monorepo
BSD 3-Clause "New" or "Revised" License
430 stars 199 forks source link

Vulcanized drawer-panel not displayed successfully in IE11 #1811

Open FranzThomsen1089 opened 8 years ago

FranzThomsen1089 commented 8 years ago

Hi

When vulcanizing this

<!doctype html>
<html>
    <head>
        <script src='bower_components/webcomponentsjs/webcomponents.min.js'></script>
        <link rel="import" href="bower_components/polymer/polymer.html"/>
        <link rel='import' href='bower_components/paper-drawer-panel/paper-drawer-panel.html'>
    </head>
    <body>
    <paper-drawer-panel id="paperDrawerPanel">
        <div drawer>
            drawer
        </div>
        <div main>
            main
        </div>
    </paper-drawer-panel>
    </body>
</html>

It does display correctly in IE. This is the same issue as in https://github.com/Polymer/vulcanize/issues/209, but it seems to have reappeared

Cheers

spirylics commented 8 years ago

+1

FranzThomsen1089 commented 8 years ago

Please look into this soon. I have a broken production site atm :-(. Thanks

Anthony2539 commented 8 years ago

+1

FranzThomsen1089 commented 8 years ago

@azakus, is there anything I can do to help getting this issue resolved? :-)

dfreedm commented 8 years ago

Sorry for the delay on this. @JustinCase1089 can you test with vulcanize 1.13.0? I can't seem to reproduce with that version on IE 11.

FranzThomsen1089 commented 8 years ago

Hi Daniel, thanks for looking into this :-). I ensured that I am using Vulcanize 1.13.0, Polymer 1.1.4 and paper-drawer-panel 1.0.3 I still got the issue with the panel http://stlucia.dhigroup.com/indexV.html holds the vulcanized page that has the problem in IE, check it out http://stlucia.dhigroup.com/index.html is the non vulcanized page http://stlucia.dhigroup.com/index.zip is the zipped site in case you want to have a look. Let me know if you need more info Cheers

dfreedm commented 8 years ago

Ah I see the issue now. Using webcomponents.js instead of webcomponents-lite.js was hiding a bug in iron-media-query. If you don't inline scripts, when iron-media-query boots up, query is undefined on this line: https://github.com/PolymerElements/iron-media-query/blob/master/iron-media-query.html#L63

dfreedm commented 8 years ago

Hmm, the media-query was only part of the problem. You're right that the dom-module is not booting up without --inline-scripts. Very odd.

FranzThomsen1089 commented 8 years ago

Really appreciating you looking into this ;-)

dfreedm commented 8 years ago

It looks like https://github.com/Polymer/polymer/pull/2201 didn't fix this, so it this is a different bug than #209

FranzThomsen1089 commented 8 years ago

Are there any workarounds for this issue for the time being?

dfreedm commented 8 years ago

--inline-scripts and --inline-css flags were working for me

FranzThomsen1089 commented 8 years ago

Yes, the workaround works in the site I had the initial problem in. Thanks

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.