[FEATURE REQUEST] Minify service-worker.js file in build process

Polymer / tools

Polymer Tools Monorepo

BSD 3-Clause "New" or "Revised" License

430 stars 200 forks source link

[FEATURE REQUEST] Minify service-worker.js file in build process #2176

Open Holi0317 opened 8 years ago

Holi0317 commented 8 years ago

Inspired by Total Tooling Tip and service worker can be minified.

This just make service worker to load faster and have a smaller size.

multimikael commented 8 years ago

The question is how much you can minify the .js file. I'm not sure, have you tried using uglify on your server-worker.js?

Holi0317 commented 8 years ago

Using a fresh app-drawer-template template and build it.

Before minified: 9.8K After minfied: 5.3K

multimikael commented 8 years ago

I don't think I quite understand. Weren't you talking about your service-worker.js?

justinfagnani commented 8 years ago

Moving this to enhancement, since it actually requires a lot of thought on how we handle streams. We'll probably need to move this bug to the polymer-build repo also.

FredKSchott commented 8 years ago

As a work around, I'd recommend running uglify on the service-worker.js file via the command line after each build.

Alternatively, You can now use the polymer-build library directly to customize your own build stream. You could uglify the service worker after it's written directly in your build task.

We'll leave this issue open as a way to gauge interest on the feature request. Please +1 the OP if you'd like to see this supported directly by the CLI.

alexnoise79 commented 7 years ago

baocang commented 7 years ago

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.