search

Polymer / tools

Polymer Tools Monorepo
BSD 3-Clause "New" or "Revised" License
430 stars 200 forks source link

HTML minify step still sends JS minify-excluded scripts to JS minifier when bundler has inlined them. #2575

Open usergenic opened 6 years ago

usergenic commented 6 years ago

Root cause of why expected excluded JS is still getting minified/compiled: https://github.com/Polymer/polymer-cli/issues/956#issuecomment-363232433

This is an unexpected behavior that bundling should essentially do an end-run around the exclusions specified. Fixing this may require some bundler work to inject identifiers into inlined code so we have a way to apply an excluded filename pattern match.

iSuslov commented 6 years ago

This is very important to fix. I can not get rid of minifying firebase-database.js which breaks my app.

usergenic commented 6 years ago

@iSuslov did you try what @christophe-g tried in his comment as a fix? https://github.com/Polymer/polymer-cli/issues/956#issuecomment-363680112

iSuslov commented 6 years ago

@usergenic yes, nothing works due to this https://github.com/Polymer/polymer-cli/issues/1008

iSuslov commented 6 years ago

Forgot to add, I downgraded to 1.6.x and it works.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.