search

Polymer / tools

Polymer Tools Monorepo
BSD 3-Clause "New" or "Revised" License
430 stars 200 forks source link

Invalid native attribute names #2747

Open yo3jones opened 6 years ago

yo3jones commented 6 years ago

Getting this browser error at runtime:

Uncaught DOMException: Failed to execute 'setAttribute' on 'Element': 'aria-live\' is not a valid attribute name.

It looks like the escape of the $ is not necessary, which leads to a trailing back slash.

Example can be seen in iron-a11y-announcer

<div aria-live\$="[[mode]]">[[_text]]</div>

will work if the \ is removed:

<div aria-live$="[[mode]]">[[_text]]</div>
venicia commented 6 years ago

Is this actively being worked on?

stramel commented 6 years ago

Probably not yet as it was opened 20 hrs ago. I'm sure it will be in the near future unless you want to put out a PR to fix it 🙂

usergenic commented 6 years ago

Added https://github.com/Polymer/polymer/issues/5060

usergenic commented 6 years ago

I can see this using .raw in Polymer's html-tag may be an issue in every other place involving a $ or escaped backtick characters etc.

usergenic commented 6 years ago

Update: This is actively being worked on in the context of Polymer/polymer 2.next and upcoming 3.0 prerelease version as we speak. Modulizer output is still going to emit the escaping for forseeable future for all dollar signs, backticks and backslashes.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.