Polymer / tools

Polymer Tools Monorepo
BSD 3-Clause "New" or "Revised" License
430 stars 200 forks source link

Expose grep links via console reporter #2882

Open thedeeno opened 10 years ago

thedeeno commented 10 years ago

For some reason it.only doesn't focus tests anymore when running in the browser (might be broken when run via server too). It seems like a wct issue.

Thoughts on where this might be breaking?

PolymerCommunityBot commented 10 years ago

The trouble with only is that we have to load all suites in order to discover a test with .only specified. That introduces a ton of extra latency for large suites (many .html files).

Your best bet is to make use of the grep functionality (I can be smart and skip files that don't match the grep expression). Click one of those arrows to the right of a test to easily grep

On Thu, Nov 20, 2014, 07:03 thedeeno notifications@github.com wrote:

For some reason it.only doesn't focus tests anymore when running in the browser (might be broken when run via server too). It seems like a wct issue.

Thoughts on where this might be breaking?

— Reply to this email directly or view it on GitHub https://github.com/Polymer/web-component-tester/issues/84.

You received this message because you are subscribed to the Google Groups "polymer-admin" group. To unsubscribe from this group and stop receiving emails from it, send an email to polymer-admin+unsubscribe@google.com. To post to this group, send email to polymer-admin@google.com. To view this discussion on the web visit https://groups.google.com/a/google.com/d/msgid/polymer-admin/Polymer/web-component-tester/issues/84%40github.com https://groups.google.com/a/google.com/d/msgid/polymer-admin/Polymer/web-component-tester/issues/84%40github.com?utm_medium=email&utm_source=footer .

thedeeno commented 10 years ago

Hmm, clicking the arrow would be perfect. The UI doesn't appear to show up with running directly via the browser. I only get console output. You seeing that too?

nevir commented 10 years ago

Ah!

So, the current logic is to show the HTML output only when you load sub suites (.js or .html) - if you view a test file directly, it defers to just console. My assumption was that people probably want to easily inspect whatever elements they set up as fixtures - and it helps keep the mocha output out of the DOM unless necessary.

I wonder if I can inject some links into the console output...

thedeeno commented 10 years ago

Oh that makes sense. So I guess we do testing a little differently. We create the element's on the fly with document.createElement and if we want to inspect we use the debugger or just log the element.

So for us, focusing a test is actually a greater concern than output - but since the output has links it's the next best thing.

Is it possible to downgrade it.only only when we run through WCT.loadSuites?

I wonder if I can inject some links into the console output...

Yeah this is possible too. Just tried console.log('link:', 'http://zombo.com') and it works as expected. Do you remember where the console output extensions are? Maybe I can patch this.

thedeeno commented 10 years ago

Side note, the links don't appear to be working when run through loadSuites. Is that just my app?

It looks like it might be generating incorrect links or grep just isn't going to work with subSuites. If I load the test page manually and add the grep query param it works as expected.

nevir commented 10 years ago

Hmm, I had a lot of breakages for the links on WCT 1.x, but squashed many in 2.0 - have you upgraded yet?

On Fri, Nov 21, 2014, 05:05 thedeeno notifications@github.com wrote:

Side note, the links don't appear to be working when run through loadSuites. Is that just my app?

It looks like it might be generating incorrect links or grep just isn't going to work with subSuites. If I load the test page manually and add the grep query param it works as expected.

— Reply to this email directly or view it on GitHub https://github.com/Polymer/web-component-tester/issues/84#issuecomment-63967176 .

Klathmon commented 9 years ago

@thedeeno I ran into a similar issue which was resolved by using absolute paths in the loadSuites call. Try doing that and see if it resolves your issue.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.