Polymer / tools

Polymer Tools Monorepo
BSD 3-Clause "New" or "Revised" License
430 stars 200 forks source link

[Polymer - build]: problem with minification #3419

Open xkotj opened 5 years ago

xkotj commented 5 years ago

Hello, I've been developing plugins for one system.

Project uses: "dependencies": { "@polymer/iron-icon": "^3.0.1", "@polymer/iron-icons": "^3.0.1", "@polymer/iron-pages": "^3.0.1", "@polymer/paper-tabs": "^3.1.0", "@vaadin/vaadin-button": "^2.2.0", "@vaadin/vaadin-checkbox": "^2.2.8", "@vaadin/vaadin-custom-field": "^1.0.1", "@vaadin/vaadin-date-picker": "^3.3.4", "@vaadin/vaadin-form-layout": "^2.1.2", "@vaadin/vaadin-grid": "^5.4.2", "@vaadin/vaadin-icons": "^4.3.1", "@vaadin/vaadin-notification": "^1.4.0", "@vaadin/vaadin-ordered-layout": "^1.1.0", "@vaadin/vaadin-progress-bar": "^1.1.0", "@vaadin/vaadin-radio-button": "^1.2.0", "@vaadin/vaadin-select": "^2.1.1", "@vaadin/vaadin-tabs": "^2.1.1", "@vaadin/vaadin-text-field": "^2.4.3", "@vaadin/vaadin-time-picker": "^1.2.2", "@webcomponents/webcomponentsjs": "^2.2.10", "lit-element": "^2.1.0", "pwa-helpers": "^0.9.1", "redux": "^4.0.1", "redux-thunk": "^2.3.0" }

I used polymer-cli for bundling and minifying polymer build --js-minify --js-compile --js-transform-modules-to-amd --css-minify --html-minify --bundle

Last functional bundle was with version polymer-cli 1.9.6

New versions (1.9.7 - 9) seems to corrupt bundled file. When I look at network activity I see that index.html is not minified in new versions

When I deploy plugin to the system I can see only this: App name ``iron-listmust be given a

My question is what is the main difference between those versions? I looked at changelog and first change was treeshaking. What else coulde be doing this?

Thanks for any hints.

homerjonathan commented 5 years ago

I have the same issue but with a completely different setup etc. Does not minify correctly. I was using polymer-cli 1.9.10. Moved to version 1.9.6 and it now works correctly.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.