search

Polymer / tools

Polymer Tools Monorepo
BSD 3-Clause "New" or "Revised" License
430 stars 200 forks source link

polymer-build remove comments #3471

Open ghost opened 4 years ago

ghost commented 4 years ago

Currently the polymer build tool leaves all comments in. If the user specifies js: minify, I believe comments should be removed. This could be achieved here:

https://github.com/Polymer/tools/blob/1fe1c22bfb81ad9195c99fa31ac24c675d15700c/packages/build/src/js-transform.ts#L286

by passing {presets, plugins, comments: false}

jonapgar commented 4 years ago

"minify"

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

quackbarc commented 6 months ago

Even supplying bundle.stripComments on polymer.json doesn't actually strip comments away, at least on Polymer 1.0 projects. It's driving me nuts.