search

PolymerElements / app-layout

App layout elements
https://webcomponents.org/element/PolymerElements/app-layout
597 stars 311 forks source link

Add TypeScript declarations to app-layout #540

Closed TimvdLippe closed 6 years ago

TimvdLippe commented 6 years ago

This PR adds TypeScript declarations generated by https://github.com/Polymer/gen-typescript-declarations/

These declarations can be re-generated by running npm run update-types.

Tracker: https://github.com/Polymer/gen-typescript-declarations/issues/79

TimvdLippe commented 6 years ago

I can't seem to get CI passing. Initially I ran the Travis pass from Tedium, but that generated a lot of changes which seemed to make Travis unhappy. Then I took the paper-button configuration (https://github.com/PolymerElements/paper-button/blob/master/.travis.yml), but even that keeps on failing. It seems to be the Chrome headless issue again.

TimvdLippe commented 6 years ago

Hm, it appears that I was watching the incorrect Travis build. Latest commit seems to be working now

aomarks commented 6 years ago

I think we want to exclude all the demos, tests, and templates, so you'd need something like this in gen-tsd.json:

{
  "excludeFiles": [
    "index.html",
    "**/test/**",
    "**/demo/**",
    "templates/**"
  ]
}
TimvdLippe commented 6 years ago

@aomarks Thanks, done!