search

PolymerElements / app-localize-behavior

Polymer behaviour to help internationalize your application
48 stars 54 forks source link

make loadResources API more flexible #111

Closed jab closed 7 years ago

jab commented 7 years ago

Fixes #75.

jab commented 7 years ago

(removed the negotiateLanguage stuff from this PR for reasons, so this is now just all about the optional params to loadResources for more flexibility. Happy to squash these commits and address any other issues after some initial feedback if there's interest in this!)

jab commented 7 years ago

I think I addressed all the issues we discussed. Squashed into a single commit that CI is currently passing for.

Thanks so much for reviewing @notwaldorf! Please let me know if you spot anything else I should do before this can be merged and I'll be happy to.

jab commented 7 years ago

Not at all, thanks for the great review!