search

PolymerElements / app-localize-behavior

Polymer behaviour to help internationalize your application
48 stars 55 forks source link

Enable pathToRessources property #21

Closed dgabrielli76 closed 8 years ago

dgabrielli76 commented 8 years ago

Before this commit, the pathToRessources propert was unused. Now you can load a dictionary using this property.

Fixes #19

notwaldorf commented 8 years ago

Oh hmm, that's definitely bad docs on my end. Sorry about that.

Can you also add a test to make sure this works, please? Also, I think the docs need to be updated -- the app-resources-loaded/app-resources-error event docs should say they get fired any time the resources get loaded from an external file (they don't just depend on pathToResources)

notwaldorf commented 8 years ago

Going to close this PR, since there's been a month and there hasn't been an answer. Please re-open it and @mention me when this is ready for another look!

dgabrielli76 commented 8 years ago

OK I understand, I have no time yet to do the test for it, if I found time I will do it, but I have seen your issue #33 so if you are going to delete this property this PR will be useless.