search

PolymerElements / app-localize-behavior

Polymer behaviour to help internationalize your application
48 stars 55 forks source link

Throw error when a key doesn't exist #48

Closed cadwmaster closed 8 years ago

cadwmaster commented 8 years ago

When a key doesn't exist now the behaviour throws a generic error (Uncaught TypeError: A message must be provided as a String or AST) and you don't know which key is the one missing.

notwaldorf commented 8 years ago

There's another PR open that wants to return the key when no translation is found. Would that work better for you? https://github.com/PolymerElements/app-localize-behavior/pull/43

notwaldorf commented 8 years ago

Closing, as I think this is superseded by #43

cadwmaster commented 8 years ago

Still think will be nice to have a warn about it, isn't the proper behaviour, is it ? Otherwise you will miss it if the app is medium/large

iceicerickert commented 8 years ago

I agree with @cadwmaster, I would like to know if I miss/forgot something. And also, the component that is failing is nice information to have during debugging. @notwaldorf Shall I create a new PR to extend the merged PR #43 ?