PolymerElements / app-localize-behavior

Polymer behaviour to help internationalize your application
48 stars 55 forks source link

Init __localizationCache if it is undefined #64

Closed monapochi closed 8 years ago

monapochi commented 8 years ago

I'd come across this issue, this.constructor.prototype. __localizationCache is undefined in iOS Safari. (Of cause, it's good in Chrome :-) ) I didn't investigate the root cause of this issue, wrote a check code.

googlebot commented 8 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


monapochi commented 8 years ago

I've signed it

googlebot commented 8 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

monapochi commented 8 years ago

Sorry, I seemed to make a mistake at rewriting the commit log, so delete this pull-req, thanks.