Safari 9.1 El Capitan - Crash on localize - Githubissues

PolymerElements / app-localize-behavior

Polymer behaviour to help internationalize your application

48 stars 55 forks source link

Safari 9.1 El Capitan - Crash on localize #92

Open kevinLB opened 7 years ago

kevinLB commented 7 years ago

Description

Actually we have a crash on old Safari browser (9.1) on El Capitan OS. The localize webcomponents seems buggy on it and crash badly.

Expected outcome

Everything is translated according to chrome / FF behaviors http://www.francetvinfo.fr/elections/resultats/export/histograms.html#lang=en

Actual outcome

Cause webcomponent crash because of localize on Safari 9.1 (El capitan). http://www.francetvinfo.fr/elections/resultats/export/histograms.html#lang=en

Steps to reproduce

Try to use "this.localize" for our translations. See errors on the browser console.

Browsers Affected

[ ] Chrome
[ ] Firefox
[x] Safari 9
[ ] Safari 8
[ ] Safari 7
[ ] Edge
[ ] IE 11
[ ] IE 10

dlockhart commented 7 years ago

@kevinLB Does the error you're seeing look something like this one:

screen shot 2017-05-15 at 3 03 29 pm

TypeError: undefined is not an object (evaluating 'proto._localizationCache.messages = {}')

If so, this is a duplicate of #74, which was fixed in #65, which made it into version 1.0.1. I've confirmed that upgrading to 1.0.1 or 1.0.2 resolved this issue for me.