PolymerElements / app-media

Elements for accessing data from media input devices and visualizing that data for users
61 stars 12 forks source link

Fix polymer 2 bug in app-media-image-capture #60

Closed j0000el closed 5 years ago

j0000el commented 5 years ago

In polymer 2, observed properties can be undefined, so properly handle those cases. Fixes bug where "Failed to construct 'ImageCapture'" exception is thrown causing subsequent calls to takePhoto() to fail.

Fixes #59

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
e111077 commented 5 years ago

Nice, please resolve the CLA issue and this PR is good to go!

e111077 commented 5 years ago

Closing. Please reopen when CLA issue is resolved. Thanks!

j0000el commented 5 years ago

I signed it!

e111077 commented 5 years ago

Can you try to kick it one more time? If not, I'd check your commit history to see if it was authored with the correct email address.

j0000el commented 5 years ago

Created https://github.com/PolymerElements/app-media/pull/61 with the correct email address.