PolymerElements / app-pouchdb

Custom Elements for working with PouchDB.
49 stars 27 forks source link

fix adapter and revslimit options when creating a new db #52

Open kasperstorgaard opened 7 years ago

kasperstorgaard commented 7 years ago

When creating a db, it seems that the adapter and revsLimit options have been switched, leading to wrong values when using either.

https://github.com/PolymerElements/app-pouchdb/blob/c06d7f0175c8c148e876247d67e81707ad807f3b/app-pouchdb-database-behavior.html#L60

...
db: {
  type: Object,
    computed: '__computeDb(dbName, adapter, revsLimit)',
    notify: true
  }
}
...

https://github.com/PolymerElements/app-pouchdb/blob/c06d7f0175c8c148e876247d67e81707ad807f3b/app-pouchdb-database-behavior.html#L230

...
__computeDb: function(name, revsLimit, adapter) {
...
googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


kasperstorgaard commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!