PolymerElements / app-route

A modular client-side router
https://www.polymer-project.org/1.0/articles/routing.html
146 stars 66 forks source link

Infinite loop when query params contain a single quote (') #162

Closed keanulee closed 7 years ago

keanulee commented 7 years ago

Description

When you set a query parameter to a string that contains a single quote (') through the queryParams property, app-location goes in an infinite loop (Maximum call stack size exceeded).

Expected outcome

No infinite loop

Actual outcome

Infinite loop

Live Demo

http://jsbin.com/zaworad/edit?html,output

Steps to reproduce

Open the console on the JSBin output and you'll see the errors.

Browsers Affected

All

keanulee commented 7 years ago

Also mentioned in this comment: https://github.com/PolymerElements/app-route/issues/157#issuecomment-259841462