PolymerElements / app-route

A modular client-side router
https://www.polymer-project.org/1.0/articles/routing.html
146 stars 66 forks source link

Fix documentation error location.pushState #172

Closed elonmallin closed 11 months ago

elonmallin commented 7 years ago

Documentation says window.location.pushState but the correct path should be window.history.pushState. (Noticed the guidelines says there should be an issue for each pull request but I'm already here and didn't create an issue for it nor found one)

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


elonmallin commented 7 years ago

Signed it. With two emails, one should be the same that I use on github.

googlebot commented 7 years ago

CLAs look good, thanks!