search

PolymerElements / app-route

A modular client-side router
https://www.polymer-project.org/1.0/articles/routing.html
146 stars 66 forks source link

Suggestion: Deprecate in favor of a library like Platinum Service Worker #214

Closed OmidHekayati closed 6 years ago

OmidHekayati commented 7 years ago

I think it is time to rethink about all elements for routing in web components projects. I am very glad to hear that Platinum Service Worker is now deprecated in favor of workbox! We must know that routing is a logic process and must do as well as service worker in programming language(JS) not a markup language(HTML)! It can be done with more painless in JS codes!

ernsheong commented 6 years ago

I am not familar with Workbox but it doesn't look like it's a 1-1 routing replacement. It should also be possible to develop web apps that are not PWAs so I'm not so sure about this.

OmidHekayati commented 6 years ago

@ernsheong I think you have misunderstood form my suggestion. I say we must have a good JS library for routing instead of many elements like app-route, app-location, iron-pages,... . workbox is a library for other requirement (service worker) of PWA architecture.

ernsheong commented 6 years ago

Well, I don't disagree with you on that. It still says on the README that app-route is a beta. And the Polymer team, looks like they're busy pushing stuff to Polymer 3 and leaving many components in so-so state. Looks like we'll have to make do for now.

e111077 commented 6 years ago

Hello, this element was very much an experiment on how we thought a modular router would work. It had its upsides e.g. declarative, modular, easy interface, but it also lot of downsides, e.g. a lot of data binding thrashing, computationally heavy, relied on a singleton app-location, brittle on initialization cases.

This element should be working for Polymer 3.0 as is, but we are looking into alternatives. And with the move to ES6 modules and npm, we think we can leverage the greater node community's current solutions. Keep an eye out in the coming weeks.